Design comparison
Solution retrospective
Hello.
This is my first attempt at the QR Code Challenge.
Please review and share insights to help improve on subsequent projects.
Thanks.
Community feedback
- @SamCastle16Posted about 2 years ago
Hi @godsonCodes! Congratulations on completing this challenge!😎
Some suggestions to improve you code:
-
You should use the main tag instead of a div(.container), because <main> represents the main content of the <body> of a document or application, it is very useful for special applications developed for people with disabilities, such as voice browsers, since they can go directly to the main topic of the document.
-
You can reduce the CSS by using the direct selector for each element (instead of using the class), this way you have even cleaner code, for example you can select everything using the direct selector for (img, h3, p and main).
I hope this helps! Happy coding!👻🎃
1@godsonCodesPosted about 2 years ago@SamCastle16 Your inputs are higly appreciated. I will do well to take note of them while working on subsequent challenges. Thanks again.
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord