Skip to content
Submitted almost 2 years ago

QR Code Challenge using flexbox

Angel Estevez•100
@AEPEX25
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This my first solution for frontendmentor using HTML and CSS. I appreciate any feedback.

Community feedback

  • Joseph Fola•590
    @Fola-JoePosted almost 2 years ago

    Nice work you have here! 😎🎊 Firstly, ensure you have all your CSS codes in your CSS file. It's a pretty good practice. So you could get rid of the style tag in the HTML file. The padding on the class .container is too much. Try reducing it to 2rem, 2.5rem, 3rem etc. Also, try making use of min-height: 100vh; rather than height: 100vh;, so that peradventure your page content gets more than usual, you can scroll to see the remaining content. I hope this helps! Happy coding!

    Marked as helpful
    1
    Angel Estevez•100
    @AEPEX25Posted almost 2 years ago

    @Fola-Joe Thank you for the feedback!!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord