QR Code challenge using FlexBox and CSS

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted over 2 years ago

  Hello there! Good job in completing this challenge. Regarding your solution, I would like you to notice the following…

  • Import the attribution style in CSS file and remove the style tag
  • Instead of div, alternatively wrap the whole content with main tag . Use semantic tags, for HTML structures, refer it with this one Semantics. This line <div class="attribution"> can be wrap with footer tag
  • Include description with the alt in image tags but it's optional
  • Simplify the padding in .container rule set into padding: 20px;

  In the bright side...

  • The CSS file is well organized and proper usage of properties
  • The HTML structure is clean and readable
  • Great use of details in the project, it's responsive and looks the same as the orginal
  • Good job in adding font weight in the font style which is basically needed for the main header

  Above all, the project is done well. Keep up the good work! Cheers!

  Marked as helpful

  0

  ---

  

  TechNech•340

  @TechNechPosted over 2 years ago

  @RioCantre Thank you for the suggestions. I will make sure I follow in future challenges.

  0