QR Code Challenge using Css flexbox

Community feedback

• 

  um1chc5•210

  @um1chc5Posted about 2 years ago

  Hi Mohammed, I have some advice for your project.

  1. You need to import the "Outfit" font using the link inside the style-guide.md into your "style.css" file or index.html you can read this to know how to do it (link)

  2. You should use exact colors mentioned in style-guide.md for texts.

  3. Modify text margin and text padding to get the best result comparing to the design.

  ---

  Have nice day ^^

  Marked as helpful

  1

  ---

  

  Mohammed Abbas•10

  @MoaDesign002Posted about 2 years ago

  @um1chc5 Thanks for helping bro💖

  0
• 

  Adriano•38,270

  @AdrianoEscarabotePosted about 2 years ago

  Hi Mohammed Abbas, how are you? Welcome to the front-end mentor community! I really liked the result of your project, but I have some tips that I think you will enjoy:

  To align some content in the center of the screen, always prefer to use display: flex; it will make the layout more responsive!

  Example:

  body {
      margin: 0;
      padding: 0;
      display: flex;
      align-items: center;
      flex-direction: column;
      justify-content: center;
      min-height: 100vh;
  }
  

  To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identify what the main title is, and follow the sequence h1-h5

  <h1 class="title">Improve your front-end skills by building projects</h1>

  The rest is great!

  I hope it helps... 👍

  0
• 

  Mohammedsalih1•240

  @Mohammedsalih1Posted about 2 years ago

  you desgin is fantastic, you should have use line-height with the paragraph,

  0

  ---

  

  Mohammed Abbas•10

  @MoaDesign002Posted about 2 years ago

  @Mohammedsalih1 Thanks💖

  0