Skip to content
Submitted 12 months ago

QR Code Challenge

Alok Acharya•80
@az0r234
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I would like to get feedback on my coding formatting.

  • Is my html structure considered best practice?
  • Is my css structure considered best practice?
  • Am I following BEM when it comes to writing css?

Community feedback

  • Daniel 🛸•44,310
    @danielmrz-devPosted 12 months ago

    Hello, @az0r234!

    About your questions

    Very good code. Both HTML and CSS.

    I'd just change the main title to <h1> instead of <h3>.

    The <h1> to <h6> tags are used to define HTML headings.

    <h1> defines the most important heading. <h6> defines the least important heading.

    Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on.

    Other than that, great job!

    Marked as helpful
    0
    Alok Acharya•80
    @az0r234Posted 12 months ago

    @danielmrz-dev Thank you for the feedback! That makes sense, I will do that next time!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord