Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Challenge Solution With HTML & CSS

WillsX9ā€¢ 20

@WillsX9

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hopped on my initial challenge after a few weeks in front-end development. I'm eager to elevate my skills through participation in Frontend Mentor Challenges and contribute to the community. I value and welcome your feedback and suggestions!

Community feedback

Daniel šŸ›øā€¢ 44,230

@danielmrz-dev

Posted

Hello @WillsX9!

Your project looks great!

  • Using margin is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:

šŸ“Œ Apply this to the body (in order to work properly, don't use position or margins):

body {
    min-height: 100vh;
    display: flex;  /* it works with grid too  */
    justify-content: center;
    align-items: center;
}

I hope it helps!

Other than that, great job!

Marked as helpful

0

WillsX9ā€¢ 20

@WillsX9

Posted

Thank you for the tip, Daniel. It was very thoughtful of you.

1
Theo Harrisā€¢ 140

@Theosaurus-Rex

Posted

Hey @WillsX9 , congrats on completing your first challenge! šŸŽ‰

There's a few things that can be tweaked here to improve the overall structure of your markup:

  • First of all, the header tag is not appropriate for this use case. Typically this tag is used for things like navigation in a web page. In this case, all of the content is a single group, and all of it can be wrapped in the main tag.
  • When providing alt text for your QR code image here, it's best to describe to the user where that QR code will take them, e.g. "A QR code linking to the Frontend Mentor website"
  • I'd recommend never using <br> in the middle of a line of text. Instead, let the text wrap within its container - this will make your content work better across a range of screen sizes

Your styling overall looks really good! I think you may have just missed the text colours but otherwise the design looks spot on šŸ™Œ

Marked as helpful

0

WillsX9ā€¢ 20

@WillsX9

Posted

Thanks a ton for your insightful comment ā€“ it's really helpful@Theosaurus-Rex

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord