Skip to content
Submitted 3 months ago

QR Code challenge solution

Ayush Kunkulol•30
@itsAyush5
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Mahmoud-AbdelKarim•600
    @Mahmoud-Abdelkarim777Posted 3 months ago
    • hi bro i saw your coding it is good but needs improve.
    • remove #container { width: 100; /* height: 350px; */ } and You forgot px in width
    • add to body {flex-direction: column; gap: 1rem;}
    • You will see the difference after these improvements.
    • wishing the best for you
    Marked as helpful
    0
    Ayush Kunkulol•30
    @itsAyush5Posted 3 months ago

    @Mahmoud-Abdelkarim777 thanks bro

    1
  • Bhuvnesh Upadhayay•2,040
    @bhuvi819381Posted 3 months ago

    Hello Brother,

    I checked your solution, and it’s looking good! Here are a few suggestions to refine it further:

    1. 📄 Upload your README file
      Make sure to use the provided README template and upload it to improve project clarity and presentation.

    2. 🔠 Use a single <h1>
      Every page should have one <h1> to ensure proper document structure.

    3. 🚫 Avoid using px
      Replace px with relative units like rem or em for better responsiveness and scalability.

    4. ✂️ Reduce the padding on your box
      Too much padding can affect the overall layout—consider minimizing it.

    5. 🔄 Set flex-direction: column in the <body>
      Applying flex-direction: column will help align your content vertically in a more organized manner.

    These adjustments will enhance your project’s quality and maintainability. Keep up the great work! 👏

    Marked as helpful
    0
    Ayush Kunkulol•30
    @itsAyush5Posted 3 months ago

    @bhuvi819381 thanks for the suggesion

    1
  • Tremy-t•350
    @Tremy-tPosted 3 months ago

    Overall, it’s a solid project. Keep up the great work, and I look forward to seeing your next update!

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord