QR Code Challenge

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi there! 👋

  Congratulations on finishing your challenge! 🎉

  Some suggestions.

  • This is already simple enough. But, there are some things that need to fix.
    • First, I recommend wrapping all the elements with a main tag.
    • After that, remove all the div.
    • Make the main element as the card element instead.
    • Then, I suggest putting the img element as the first child of the main element followed by the h2 and the p element.
    • Next, I recommend taking a look at the issues that have been generated and then trying to learn more about the issues.
    • Finally, you can update the code in the repository by pushing the latest changes. Then, try to generate a new report.
  • If you still see any issues then try to fix them. 😉
  • I notice a .DS_Store inside the resources/ folder. This can be prevented by keeping the .gitignore file both on your local machine and the GitHub repo. (For your information, by the time you downloaded the "Starter files", it already came with the .gitignore file).

  That's it! Let me know if you have any questions. Hope this helps. 😁

  1

  ---

  

  Hamzat Lawal•560

  @EngineerHamzieyPosted over 2 years ago

  @vanzasetia thanks for your regular helpful comments 😢 Seriously my eyes always ignore the learn more button. I'll instead be waiting for people to comment how I can solve those issues which is bad.

  But I'll start using the learn more

  1