Qr Code - Challenge (Just HTML/CSS)

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  QR iMAGE ALT TEXT 📸:

  • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.

  ---

  • The alt with image-qr-code is not even explaining for what the QR image need to be used.

  ---

  • So update the alt with meaningful text which explains like QR code to frontendmentor.io

  ---

  • Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Adriane Santos•30

  @AdrianeSantosDevPosted over 1 year ago

  Hello @0xAbdulKhalid I will improve the image alt text. Thank you for providing feedback; I appreciate it!

  0
• 

  Rohit Deshpande•870

  @rohitd99Posted over 1 year ago

  Hi Adriane

  Congrats on completing the challenge.

  I have a few suggestions for you.

  1. Look into semantic elements like main,section,article and others , try to use them instead of div. In this case you can replace the div class="block" with main since the card is the only content or you can have the div inside main.
  2. Add a little bit of padding to your body like padding: 1rem; or so on mobile sizes the content doesn't span the entire screen and there is a bit of space left on the sides.
  3. Inside the text div the title should be a h1 heading instead of span. Also each page must have a single h1 heading signifying the title of the page for accessibility and SEO reasons. Headings must always be from h1 through h6 in order.
  4. On body you have height: 100vh; instead keep min-height: 100vh so that content expands as per need.
  5. On the block you have height and width properties , but these properties will not scale down if the screens are smaller so I'd suggest using max-width only and let the height adjust as per content. This will ensure that on smaller screens the width adjusts itself. The img must also have width : 100% , this ensures it covers the entire card. Add padding : 1rem to the block to have some space.

  Hope it helps

  Marked as helpful

  0

  ---

  

  Adriane Santos•30

  @AdrianeSantosDevPosted over 1 year ago

  Hello @rohitd99 Thank you for the tips! I was a bit confused when it came to setting the font size and widths, but your feedback has been really helpful. I appreciate it!

  0