qr-code-challenge

Hello, good job on this challenge!

Here are some suggestions for an even better solution - I hope they help :)

HTML:

• The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

CSS:

• Including a CSS Reset at the top is good practice.

• Since Outfit is a sans-serif font ,change font-family: "Outfit", serif; to font-family: "Outfit", sans-serif;

• I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

• I would move the styles on .main to body.

• Remove the margin on the card, as it is already centered using Flexbox.

• Remove width and min-width on the card. Instead, give it a max-width of 20rem, so it doesn't get too wide on larger screens.

• On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

Hello @calixmnt,

Great job completing the challenge. The solution is significantly close to the design.

However, I'll like to suggest that the border-radius: 10px; increased to about border-radius:14px could make the solution even look better.

Happy coding!