QR code challenge html & css only

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <h2> with <h1> to fix the accessibility issue.

  This challenge does not require a box-shadow, there is no need to give .card and the box-shadow values.

  To center .card on the page using flexbox, replace the height in the main with min-height: 100vh.

  For a responsive content which wont require a media query for this challenge, give .card a fixed max-width value instead of a percentage width value. e.g: max-width 320px.

  There is no to give to .card a height value.

  Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Tad Atkinson•160

  @palmettophotoPosted almost 2 years ago

  @Hassiai thanks for the detail in your comment. You helped me trim a subtantial amount of excess code from my css. Thanks for your willingness to help a newbie.

  1