Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code challenge html & css only

@palmettophoto

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


First attempt at solving a challenge...ever! So any and all advice, critique, etc is appreciated and I thank you in advance. ~Taddo

Community feedback

Hassia Issah 50,670

@Hassiai

Posted

Replace <h2> with <h1> to fix the accessibility issue.

This challenge does not require a box-shadow, there is no need to give .card and the box-shadow values.

To center .card on the page using flexbox, replace the height in the main with min-height: 100vh.

For a responsive content which wont require a media query for this challenge, give .card a fixed max-width value instead of a percentage width value. e.g: max-width 320px.

There is no to give to .card a height value.

Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

1

@palmettophoto

Posted

@Hassiai thanks for the detail in your comment. You helped me trim a subtantial amount of excess code from my css. Thanks for your willingness to help a newbie.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord