QR Code Challenge completed with HTML and CSS using Flex Box

HTML:

• Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" content. Wrap the card in a <main>.

• You can remove the <div> wrapping the image, and the one wrapping the text, as none are needed.

• The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

• I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

CSS:

• Including a CSS Reset at the top is good practice.

• Use the style guide to find the correct font-family, and remember to specify a fallback font:font-family: 'Outfit',sans-serif;

• I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

• On the body, change height to min-height: 100svh - this way, the content will not get cut off if it grows beneath the viewport.

• Remove all widths in px.

• Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

• font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

• letter-spacing must also not be in px. You can use em, where 1em equals the element's font size. NB: Whenever the value is zero, you simply write 0 - there is no need to include any unit.

• On the image, add height: auto, display: block and replace min-width with max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.