QR code challenge

Community feedback

• 

  mubizzy•1,520

  @mubizzyPosted over 2 years ago

  Excellent job on this challenge! your report has a few issues though:

  1. wrap everything in your body in <main> or use semantics

  2.   it is a best practice to use both HTML 5 and ARIA landmarks to ensure all     content is contained within a navigational region.

  Hope it helps:)...don't forget to mark it as helpful 👍

  You can get more details here...click here

  Marked as helpful

  0
• 

  Macaulay Omoikhoje De-great•550

  @MacChristoPosted over 2 years ago

  1.when you put an image on the screen, you need to style it by tweaking the width, height, etc

      font-family: "Outfit" , 'sans-serif';
      font-size: 15px;
      background-color: var(--light-gray);
      display: flex;
      flex-direction: column;
      align-items: center;
      justify-content: center;
      height: calc(100vh-1px);   *<---Remove*
      /* margin: 1.25rem; */      *<----Remove*
      align-content: center;
      height: 100vh;                     *<----Add*
  }
  

  for the container-div

  .container {
      max-width: 320px;
      justify-content: center;
  }
  

  Remove the padding on the container-img

  .container h1 {
      color: var(--dark-blue);
      text-align: center;
      margin-bottom: 1rem;
      max-width: 285px;      *<----Add*
      font-size: 22px;           *<----Add*
  }
  

  .container p {
      color: var(--grayish-blue);
      text-align: center;
      max-width: 260px;     *<---Add*
  }
  

  .attribution {
      font-size: 11px;
      text-align: center;
      position: relative;      *<----Add*
      top: 2rem;                  *<---Add*
  }
  

  Hope this helps....Happy coding

  0
• 

  faizan•2,420

  @afaiz-spacePosted over 2 years ago

  Hey @Abbyiegirl,

  • add width:25rem; in the container class.
  • Remove padding: 1.5rem; from img element.

  0

  ---

  

  Abigail•10

  @AbbyiegirlPosted over 2 years ago

  @afaiz-space thanks i'll try this.

  0