Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Qr code challenge

@JessyTsiriniaina

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P

@Islandstone89

Posted

HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify the "main" section of a page. As the card is the only "main" content on this page, you can change .card into a <main>.

  • The alt text also needs to say where it leads (frontendmentor.io).

CSS:

  • It's good practice to include a CSS Reset at the top.

  • You don't need to set width: 100vw on the body, as that is its default value. Also, height should be min-height - this way, the content will not get cut off if it grows beneath the viewport.

  • Remove the fixed width and height on the card. Except for icons, you rarely want to set fixed dimensions(especially heights), as this easily creates issues with responsiveness.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is bad for accessibility, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value. Hence, you can also remove margin: 0 auto on the text elements.

  • Add display: block and max-width: 100% on the image - the max-width prevents it from overflowing its container.

  • There is no need to set font-weight: 400 on <p>, as that is its default value.

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord