Qr code challenge

Community feedback

• 

  P

  Øystein Håberg•10,550

  @Islandstone89Posted 10 months ago

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify the "main" section of a page. As the card is the only "main" content on this page, you can change .card into a <main>.

  • The alt text also needs to say where it leads (frontendmentor.io).

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • You don't need to set width: 100vw on the body, as that is its default value. Also, height should be min-height - this way, the content will not get cut off if it grows beneath the viewport.

  • Remove the fixed width and height on the card. Except for icons, you rarely want to set fixed dimensions(especially heights), as this easily creates issues with responsiveness.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is bad for accessibility, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value. Hence, you can also remove margin: 0 auto on the text elements.

  • Add display: block and max-width: 100% on the image - the max-width prevents it from overflowing its container.

  • There is no need to set font-weight: 400 on <p>, as that is its default value.

  Marked as helpful

  1