Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I am proud of being able to finish it...
What challenges did you encounter, and how did you overcome them?The challenge was to do everything on my own mainly but when all was said and done, I really felt proud of myself.
What specific areas of your project would you like help with?The width property mainly, idk which unit to use for it
Community feedback
- @0xabdulkhaliqPosted 8 months ago
Salaam Alaikum 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
HEADINGS ARE NOT PROPERLY USED ⚠️:
- This solution consists incorrect usage of
<h3>
so it can cause severe accessibility errors due to incorrect usage of level-three headings<h3>
- Every site must want only one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- In this solution there's
<h3>
element which is this<h3>Improve your...</h3>
, you can preferably use<h1>
instead of<h3>
. Remember<h1>
provides an important navigation point for users of assistive technologies so we want to use it wisely
- So we want to add a level-one heading to improve accessibility
- Example:
<h1>Improve your front-end skills by building projects</h1>
- If you have any questions or need further clarification, and feel free to reach out to me.
- If you have any questions or need further clarification, you can always check out
my submission
and/or feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @mathematiCodePosted 5 months ago
It looks good! You could include a top margin or center the card within the body to center it more.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord