Submitted 8 months ago

QR Code Challenge

Anton• 30

@Antonx95

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

Hello everyone, this is my first challenge completed, I would like to know if the width of this page is correct as the challenge requested or i understood wrongly. Thank You in advance

Community feedback

Daniel 🛸• 44,230

@danielmrz-dev

Posted 8 months ago

Hello @Antonx95!

Your solution looks great!

I have a suggestion for improvement:

Use <main> to wrap the main content instead of <div>.

📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.

This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

Marked as helpful

Aykın Sancaklı• 680

@aykinsancakli

Posted 8 months ago

Hello @Antonx95,

Your solution looks great!

📌 A Couple of suggestions:

After <body> tag you can wrap your content inside the <main> tag. The <main> HTML element represents the dominant content of the <body> of a document. This way you are denoting that the part inside the <main> element is the core content of your website.

Instead of using generic <div class="container"> you can use <article> element that specifies independent, self-contained content (e.g. product card, a forum post).

Those are Semantic HTML elements and they add meaning to content for better understanding by browsers, developers, and accessibility tools, improving overall web page structure and SEO.

You can add the attribution <div> after the card so that it will not take part in the card element but end of the body.

Hope this helps, great work overall!

Cheers,

Aykın

Marked as helpful

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord