QR Code - Challenge

Community feedback

• 

  Adriano•38,040

  @AdrianoEscarabotePosted almost 2 years ago

  Hi Yuri Mendes, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

  To improve the structure of the html document, prefer to wrap all the content with the main tag, since this challenge is just a component, it needs a main tag to know what the main content of the page is!

  Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Yuri Mendes•130

  @Yuri-MendesPosted almost 2 years ago

  @AdrianoEscarabote Thank you very much for your feedback, it is really helpful, and I'm glad you did. I need to learn more about main tag and start to use it on my challenges and projects. Also, I was reading an article about using rem for font size, and I will start to use it. Thank you very much, again!

  1