QR code challenge

Community feedback

• 

  P

  Boris•3,970

  @makogeborisPosted 2 months ago

  Great job completing your first challenge, here are some suggestions

  • To properly center the card, add a min-height: 100vh; on the body and remove the margin-top property from the .container
  • It's best to avoid using fixed heights and widths to ensure your design stays responsive. Instead, try setting the .container width as max-width in rem units, and remove the height property altogether. Let the content and padding naturally define the size.
  • All content should be wrapped within landmarks. Wrap a main tag around the .container and a footer for the .attribution
  • The image don't need to be wrapped in an anchor tag, what it needs is a descriptive alt attribute like so alt="QR code linking to Frontend Mentor"
  • Font-size should be written in rem not px
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
  • Use a separate file for your CSS as it improves maintainability.

  Hope this helps, Good luck!

  Marked as helpful

  1
• 

  Tonmoy Sarker•120

  @tonmoysarkerPosted 2 months ago

  Solution did not adhere to the design in regards to font colors, spacing between image and typography (margin, padding).

  0