@asimsaeed353
Posted
The design is great and looking very fine. Your HTML is properly structured. Although you could have used <h2> or <h3> instead of <p class="text-preset-1">Improve your front-end skills by building projects</p>.
And I suggest not to set max-width at least on <body> and avoid setting fixed heights and widths. If you need to set width, try using '%' rather than fixed values. And, it's good to see you have used 'rem' for font sizes.
Overall, it's a amazing. Keep up the good work!
Marked as helpful
@asimsaeed353
This is very helpful, thank you! As for the height, I tried not to include it, but I'm unable to vertically center the card on the page using flexbox. I'm probably missing something. Is there a way to get the card in the middle of the page without using the height?
I was thinking about the headings, but went off of the Figma design thinking I should follow the variables that are set in Figma, lol.
@asimsaeed353
Posted
@lillakm To place the card in the middle you can use
body{
display: grid;
place-items: center;
min-height: 100vh;
}
Try this and must let me know if it works.
Marked as helpful
@asimsaeed353
Posted
@lillakm Figma file does help a lot in designing but I suggest don't take the variables in the Figma file too seriously. I don't do this at least, lol.
@asimsaeed353
Works like a charm! Thank you so, so much! I still need to understand when it's better to use grid vs flexbox but this makes so much sense!
@asimsaeed353
I work on the design side, so I assumed to follow the design, thinking the naming system has been agreed upon... unfortunately, I know it's not exactly true in real life, lol!
@asimsaeed353
Posted
@lillakm Flexbox and grid both have their use cases. I have started using grid more for designing layouts and I'm pretty impressed with the simplicity it offers. Currently, I've designed a layout that I thought would be challenging but grid made it very easy. It helped me get more done with very few lines of codes.
Marked as helpful
@asimsaeed353
Posted
@lillakm what I have learnt so far, is there are no hard and fast rules to implement the design. You have to improvise often. And it's great to know you are a designer. Since you already know how to design, you'll be a great addition to the fronted family :). Let me know if you need help with anything. Keep up the good work!
@asimsaeed353 Thank you so much for all the feedback and I'll keep it in mind to be flexible. It's the same in design :)
@asimsaeed353
Posted
@lillakm Looking forward to more cool designs from you.
