QR Code challenge

Community feedback

• 

  Marcus Rangel•460

  @WebDevCamposPosted about 2 years ago

  Hi there! Congratulations on posting your first challenge! You did great, but if you allow me, here are a few suggestions: Firstly, always look at style-guide.md file that comes with the project. There you'll see the proper colors and sizes, for typography and for the elements. So you can see that you have to fix the Improve your front-end skills by building projects color. Actually it leads me to another topic: all projects must have a h1 tag, so this very text is a h1. If you feel that the default font-size for this element is bigger than you like, than just set your own size. Here is a tip to center your main element: body { background-color: hsl(212, 45%, 89%); font-family: Outfit; display: flex; justify-content: center; align-items: center; height: 100vh; } Doing this, you won't need to set a margin that big for your component and you won't need to set a heightor overflow either. These are the frist steps to improve your solution. If you feel like, you can reach me out and we can work together! Kind regards!

  Marked as helpful

  0

  ---

  

  jakotide•10

  @jakotidePosted about 2 years ago

  @WebDevCampos Thank you for great feedback! Quite new to this so have lots to learn. Finding it hard to know when to use flex etc or not, but that will come over time i guess!

  0