QR Code Challange HTML/CSS

Community feedback

• 

  Robert Mizianty•130

  @robmi11Posted almost 3 years ago

  In your HTML file you have left some styles. I recommend to move them to your css file. Also, you could consider using of some sematic HTML tag. For example, that last/bottom div with information about you and where to find this challenge is perfect candidate to be <footer></footer>. If you use Visual Studio Code, please consider using prettier. This plugin will format you code (indents, removing empty lines, or be consistent with single or double quotes), each time you save your file. An <img /> tag should always have an alt="" attribute, even empty one.

  Marked as helpful

  1

  ---

  

  TomekSwitecki•160

  @TomekSwiteckiPosted almost 3 years ago

  @robmi11 Thanks! I will definitely look into that!

  0
• Account deleted

  Without any issues

  Hi there 👋

  Congratulate on finishing your project 🎉. You did a great job 🔨

  About your GitHub, I think you should improve the readme file because good readme helps you get a job faster. You can find some readme designs online 👍

  Happy coding ☕

  Maqsud

  Marked as helpful

  1

  ---

  Account deleted

  @TomekSwitecki Use my template if you want https://github.com/maqsudtolipov/profile-card-component

  Marked as helpful

  1

  

  TomekSwitecki•160

  @TomekSwiteckiPosted almost 3 years ago

  @maqsudtolipov Thanks! I really appreciate your help and feedback!

  1