Skip to content
Submitted about 2 years ago

QR Code Challange

Samed•10
@SamedLepir
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

My first project here, any feedback is welcome! :)

Community feedback

  • 101Amine•260
    @101AminePosted about 2 years ago

    • Hello @SamedLepir, congratulation on completing this challenge!

    1 - The image doesn't show because u'll need to add a dot before the image path, './images/..'

    2 - I think it would be much better to just use the img tag directly <img src='..' alt='..' />

    3 - And as Mr @Hyron mentioned in one of his comments, instead of using margin to center the div you can use flexbox

    body {
    background-color: hsl(212, 46%, 89%);
    display: flex;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
}

    Hope this was helpful for you, happy coding

    Marked as helpful
    1
    Samed•10
    @SamedLepirPosted about 2 years ago

    @101Amine Thanks buddy, it was helpful :)

    0
  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hi @SamedLepir, congratulations on your first solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

    1.Replace the <h3> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.

    2.Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

    3.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

    4.Use a CSS reset to avoid all the problems you can have with the default CSS setup, removing all margins, and making the images easier to work, see the article below where you can copy and paste this CSS code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

    ✌️ I hope this helps you and happy coding!

    0
  • Adriano•38,270
    @AdrianoEscarabotePosted about 2 years ago

    Hi Samed, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    The rest is great!!

    Hope it helps...👍

    0
  • Deepanshu Gupta•590
    @Deepanshu-5288Posted about 2 years ago

    Hello Samed, Try with removing the forward slash from image URL like this - background-image: url("images/image-qr-code.png");

    I hope this works. Thanks

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord