QR code Card with some margins

Community feedback

• 

  Adriano•38,040

  @AdrianoEscarabotePosted about 2 years ago

  Hi matistikoff, how are you?

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag.
  • To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identity what the main title is.

  Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  1

  ---

  

  matistikoff•30

  @MatistikPosted about 2 years ago

  @AdrianoEscarabote hello, wasn't expecting this kind of feedback,

  thank you very much, i'll try to follow your points in next challenges

  1

  

  Adriano•38,040

  @AdrianoEscarabotePosted about 2 years ago

  @Matistik happy coding!!

  1
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi @Matistik, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  • Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
  • Replace the <h3> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
  • Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.
  • Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  1