QR code card using HTML, CSS

Community feedback

• 

  Daniel 🛸•44,270

  @danielmrz-devPosted 10 months ago

  Hello @tharidu678!

  Your solution looks great!

  I have a couple of suggestions for improvement:

  • First: In order to make your HTML code more semantic, use <h1> for the main title instead of <div>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  • Second: Still about semantic HTML, use <main> to wrap the main content instead of <div>.

  All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1
• 

  raya•2,870

  @rayaattaPosted 10 months ago

  Hello Tharindu D👋, congratulations on completing your first FED challenge 🎉

  I have some suggestions you might find useful.

  1 Try to make your html more Semantic by wrapping the main page content inside a <main> tag . Replace <div class="card"> With <main class="card">. This changes nothing visually but Using it makes all the difference. Using semantic markup improves

  SEO

  And user experience (accessibility) for people using assistive technology such as screen readers.

  2 The qr code should have text inside an alt attribute stating what it is and where it leads i.e alt="qr code leading to frontendmentor.io

  3 I noticed

  <div class="title">
  

  in your html. Divs do not carry any semantic value therefore you should replace it with

  <h1 class="title">
  

  I hope this helps 🙃

  Otherwise your solution is neat👍

  Happy coding ✌️

  Marked as helpful

  1