qr code card using css flex-box

Community feedback

• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Here are my suggestions..

  • You should use <main class="container"> instead of <div class="container">.
  • Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.
  • You can wrap your attribution section in a footer tag to avoid accessibility issues.

  This should fix most of your accessibility issues

  . Regardless you did amazing... hope you find this useful... Happy coding!!!

  Marked as helpful

  0
• 

  P

  Kent O'Sullivan•1,870

  @12KentosPosted over 2 years ago

  Hello @gabrielCarrenio Nice job on your first project! :)

  I'm assuming your question is regarding the following code from your CSS?

  * { padding: 0; margin: 0; font-family: "Outfit", sans-serif; color: hsl(218, 44%, 22%); }

  Usually the * (universal selector) is used for resetting the page's margin, padding and setting the box-sizing to border-box. I would try not to use it for too much else, at least for now. There are quite a few use cases for it, in some more advanced CSS/SASS but for now I would probably stick to using it to reset the page, like I mentioned.

  As for if it's good practice, pretty much any front end developer that I've seen uses it like I mentioned, so I would say yes.

  Hope that helps!

  Marked as helpful

  0