Skip to content
Submitted over 1 year ago

QR code card using css and html

Jonfernando Alfaro•100
@Jxnfernandx
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I am still having a hard time adjusting my code to fit mobile devices. I would also like to incorporate more grid and flex box into my code.

Community feedback

  • Abdul Khaliq 🚀•72,580
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    COMPONENT MEASUREMENTS 📐:

    • Use min-height: 100vh for body element instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.
    • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh.
    • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    0
    Jonfernando Alfaro•100
    @JxnfernandxPosted over 1 year ago

    @0xAbdulKhalid Thank you so much for your feedback! I really appreciate you taking the time to help me out

    0
  • ilyemm•140
    @ilyemmPosted over 1 year ago

    Hey Jonfernando,

    Great job with the design! It looks very similar to the original.

    Looking through your code, I see you set a lot of fonts, widths, and heights with pixels which are absolute units. This means the font will stay that pixel size regardless of the layout. What I've been recommended to help with making things more responsive is looking into rem/em which can help with making the font, width, and height more responsive.

    A video I personally thought was a great starting point into understanding the different units of measurement CSS has been Kevin Powell's "Are you using the right CSS units?" where he gives a general outline of which units he uses in which scenarios. In general, Kevin Powell is a great resource for CSS.

    Hope this helps, and happy coding! :)

    Marked as helpful
    0
    Jonfernando Alfaro•100
    @JxnfernandxPosted over 1 year ago

    @ilyemm much love to you! Thank you for words of wisdom.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord