Skip to content
Submitted about 2 years ago

QR Code Card using basic css

Mauger•210
@mauger1998
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This is the first thing I have ever built without following a tutorial, it is just basic html and css but I am happy to know I can do this with no help.

Community feedback

  • Hyron•5,870
    @hyrongennikePosted about 2 years ago

    Hi @mauger1998,

    Congrats on completing the challenge

    Instead of using margin to center the card you can use flexbox. Replace you body rule with the following.

    .card {
    margin: 0;
}

body {
    background: lightgrey;
    display: flex;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
}

    You can use the below website for eloquent box shadows, just click the one you want and paste it in the CSS rule.

    https://getcssscan.com/css-box-shadow-examples

    Also check the report above there are issue.

    Hope this is helpful. Let me know if you have any other questions.

    Marked as helpful
    1
    Mauger•210
    @mauger1998Posted about 2 years ago

    @hyrongennike Awesome thanks for the tips, Im stuck in tutorial hell right now so I thought this site would be great to try and do some things on my own, thanks again

    0
  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hi Mauger, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

    1.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

    2.When you download the project files there’s a file called style-guide.md where you can find information such as hsl color codes and the font-size for the headings. The background-color in this case is background-color: #D5E1EF

    3.Use relative units like rem or em instead of px to have a better performance when you page content resize in different screen and devices. REM and EM does not just apply to font size, but to all sizes as well. To save your time you can code you whole page using px and then in the end use a VsCode plugin called px to rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

    4.The html structure is fine and works, but you can reduce at least 20% of your code cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
  • Mauger•210
    @mauger1998Posted about 2 years ago

    Thanks this really helps, I thought the HTML looked very cluttered, this is great feedback!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord