Skip to content
Submitted about 2 years ago

QR Code Card, Second attempt after feedback

Mauger•210
@mauger1998
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

For some reason when this site shows a screenshot of my solution to compare with the design it isnt the same as if you go to my site online, this is better than my first attempt

Community feedback

  • Adriano•38,120
    @AdrianoEscarabotePosted about 2 years ago

    Hi Mauger, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Document should have one main landmark, you could have put all the content inside the main tag click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    The rest is great!!

    Hope it helps...👍

    Marked as helpful
    0
    Mauger•210
    @mauger1998Posted about 2 years ago

    @AdrianoEscarabote This is great advice thanks

    1
  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hello Mauger, Congratulations on completing this challenge!

    Unfortunately your live site is not previewing, due an error with the Github Pages I don’t recommend it since it's too hard to set up.

    If you really want to use Github Pages you can try to follow this guide to use it and fix the settings for your page https://docs.github.com/en/pages/quickstart.

    My suggestion it that you use vercel.com or netlify.com that are really easier platforms for live sets and totally user-friendly, in a matter of 5min your live site is online. All you need to do is to connect the Github account, import the repository and deploy it. Really fast.The easy one is Vercel and is the one I use for my solution.

    Fixing that you've to update the solution with the new link and we'll be able to see your live site and help you.

    ✌️ I hope this helps you and happy coding!

    0
    Mauger•210
    @mauger1998Posted about 2 years ago

    @correlucas Oh thanks for telling me its because I renamed all my repos ill sort it out now

    0
  • Kawsar Ahmed Fahad•2,660
    @faha1999Posted about 2 years ago

    Hello Mauger. Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:

    • You might want to use semantic tags like the <main> to wrap your code, instead of div `s.

    • You could also make use of <section> and/or <article> semantic tags. This would help improve accessibility.

    • remove width: 1440px; from body it will be responsive.

    I hope this helps you. Happy Coding!

    0
    Mauger•210
    @mauger1998Posted about 2 years ago

    @faha1999 Hey thanks alot for your feedback its very valuable advice, i have just finished another challenge the NFT card and I took some of your advice you should check it out!

    0
  • Mauger•210
    @mauger1998Posted about 2 years ago

    I dont know why but the screenshot this site is showing is not the same as the site looks when you actually go to it

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord