@AdrianoEscarabote
Posted
Hi Berndoe, hope you're doing well! I loved how your project turned out, but I’ve got a few suggestions that could be useful:
Since this project is only based on a single page component, there is no need for a h1 tag. It's always a good idea to prevent accessibility errors, so I believe it would be beneficial for you to add a "h1" in this component. Don't worry if you forget about "h1," though; it's a good practice for when you are developing larger sites.
<h1>Improve your front-end skills by building projects</h1>
You have used <br> , using <br> is not only bad practice, it is problematic for people who navigate with the aid of screen reading technology. Screen readers may announce the presence of the element. This can be a confusing and frustrating experience for the person using the screen reader.
The rest is fantastic.
Hopefully, you'll find it helpful. 👍
Marked as helpful
@Berndoe
Posted
@AdrianoEscarabote thank you for your feedback. Is using <br> only bad for in between texts only? Also, can you suggest an alternative to achieve the same effect.
@AdrianoEscarabote
Posted
@Berndoe I prefer to use max-width and set a maximum width for my element