Skip to content
Submitted over 1 year ago

QR Code Card | HTML/CSS

Kirsten ✨•460
@ofthewildfire
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This was my first ever challenge last year; I have done it again. Following a list posted on Discord of the challenges in order to get done, this is number one and my first solution was not good, I didn't know many things and now I have done it again.

Any feedback please, I would greatly appreciate.

Edit: 1st August 2023: I have added the change to the alt attribute as suggested and fixed a few other things, mainly the zoomy-zoom on the page no longer chops the content in half. :)

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    QR iMAGE ALT TEXT 📸:

    • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.
    • The alt with qr code is not even explaining for what the QR image need to be used.
    • So update the alt with meaningful text which explains like QR code to frontendmentor.io
    • Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    0
    Kirsten ✨•460
    @ofthewildfirePosted over 1 year ago

    @0xAbdulKhalid Will edit, thank you for your feedback!

    0
    Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    @ofthewildfire Glad you found it helpful ! 🤠

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord