QR code card component with html & css

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution consists incorrect usage of <h2> so it can cause severe accessibility errors due to incorrect usage of level-two headings <h2>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's <h2> element which is this <h2>Improve your...</h2>, you can preferably use <h1> instead of <h2>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility

  ---

  • Example: <h1>Improve your front-end skills by building projects</h1>

  ---

  • If you have any questions or need further clarification, and feel free to reach out to me.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Alan Piñón•160

  @AlanPinhonPosted over 1 year ago

  @0xAbdulKhalid

  Hello 👋 .

  Thanks for the observation. I will take that advice into account for the next practices.

  If any doubt or question arises, I will gladly let you know.

  Happy coding! 😄

  0
• 

  vivekrajput@93•450

  @vivekrajput-93Posted over 1 year ago

  Well done brother, u did good , but I would prefer the appyling the font-family which is given in the instruction, cos it perfectly match with component, over all looks great to me.

  0

  ---

  

  Alan Piñón•160

  @AlanPinhonPosted over 1 year ago

  @vivekrajput-93

  Thank you very much bro.

  In fact, I applied the requested font in practice, but apparently it was not applied in the final result. :(

  0