QR code card component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="card"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  ---

  • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  iMAGES 📸:

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute.

  ---

  • The alt attribute should explain the purpose of the image.

  ---

  • E.g. alt="QR code to frontendmentor.io"

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Brian Michael Poblete•490

  @Brian-PobPosted over 1 year ago

  Hello there brunokzz 🙋‍♂️! Great job on this challenge 🎉!

  Putting display: flex on the body is not always a bad thing in my opinion. As long as you are aware of what it does and it works for your needs you should be fine.

  However, if you wanted to keep styles off of the body you could create a wrapping div around your content that takes up the whole space of the body. You could also target the main that should be present in your site's markup.

  You could actually replace the <div class="card"> with a main tag to resolve the accessibility (sometimes abbreviated as a11y) report.

  Here are a few links that should help you resolve the errors and warnings generated for your site.

  Accessibility ♿️:

  • Alt text
  • Level one heading
  • Document should have one main landmark

  HTML Validation Report 🔨:

  • You can add alt text to your image that describes the image or what it is for.

  I hope this helps! ✌️

  I look forward to seeing more of your work in the future! 😄

  0