@Sachin-Mahato
Posted
Well done for completing the challenge
As a front-end developer, your job is to make the website look just like the designer wants it to. If there are any differences, try to fix them quickly so that the website matches the design as soon as possible.
This challenge consists of two parts: the mobile component and the desktop component. However, it appears that the mobile part has not been developed. It's important to address this issue and ensure that both the mobile and desktop aspects of the challenge are completed.
.Do not forget ⚠️ to check your FEM report (It provides value information), to see what is incorrect and update your code with it. This should be done immediately after submitting your challenge.
1. Lack of semantic HTML:
- Semantic HTML elements are missing or not used appropriately.
- The structure does not convey the meaning and purpose of different parts of the webpage.
-.Every site should ALWAYS have ✅ a main element not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, it will serve as the component’s container
--
.Avoid skipping heading levels ⚠️.
- Always start with the h1 (which can only be used once) and you will go down the hierarchy level depending on the heading’s level of importance.
2. Usage of absolute units instead of relative units:
- Absolute units like pixels (
px) are used for defining lengths and sizes instead of relative units like percentages (%),em, orrem. - Relative units are more flexible and responsive across different screen sizes.
Your CSS Reset is being underutilized😢 To fully maximize 💯 it, you will want to add more to it. Here are some examples that you can freely use 😁: Josh Comeau Reset Eric Meyer Reset
I hope you find this helpful and happy coding
Marked as helpful
@Arfirpo
Posted
Thanks for your suggestions @Sachin0000000 , they were very helpful! I'll keep them in mind for the correction of this challenge and for future projects.
