QR Code Card Component

Community feedback

• 

  _nehal💎•6,710

  @NehalSahu8055Posted over 1 year ago

  Hello Coder 👋.

  Congratulations on successfully completing the challenge! 🎉

  Few suggestions regarding design.

  • Wrap up .attribution inside <footer> as per semantics rule .

  <footer>
  <div class="attribution">
  ....
  </div>
  </footer>
  
  

  -For non-decorative images give meaningful and descriptive alt like alt= "QR code to Frontend Mentor website".

  • Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

  link.

  • You can use accessibility features like aria, sr-only, and title which are accessible to screen readers.

  I hope you find this helpful.

  Happy coding😄

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  QR iMAGE ALT TEXT 📸:

  • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.

  ---

  • The alt with qr code is not even explaining for what the QR image need to be used.

  ---

  • So update the alt with meaningful text which explains like QR code to frontendmentor.io

  ---

  • Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0