Skip to content
Submitted about 2 years ago

QR code card component

Abhishek Roy•50
@abhishek-Roy22
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I learn lot of things.

What challenges did you encounter, and how did you overcome them?

Honestly, I do not encounter any problem

What specific areas of your project would you like help with?

style parts

Community feedback

  • Adriano•38,080
    @AdrianoEscarabotePosted about 2 years ago

    Hi Abhishek Roy, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

    The rest is great!!

    Hope it helps...👍

    0
  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hello @abhishek-Roy22, congratulations on your first solution!👋 Welcome to the Frontend Mentor Coding Community!

    Nice code and nice solution! You did a good job here putting everything together. I’ve some suggestions for you:

    1.When you download the project files there’s a file called style-guide.md where you can find information such as hsl color codes and the font-size for the headings.

    This is the correct color for the background body { background-color: hsl(212deg 66% 92%);}

    The correct value for this shadow is box-shadow: 5px 5px 15px 5px rgb(0 0 0 / 3%);

    2.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

    3.You need to import the correct font that is Outfit. First of all you need to choose the font using Google Fonts

    https://fonts.google.com/ and import the code to drop on your CSS/HTML:

    Here’s the css code for this font and should be placed at the top of your CSS sheet: @import url('https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,300;0,400;0,700;1,400&family=Outfit:wght@300;400;600;700&display=swap');

    Add this to the body to add the font to the style: font-family: 'Outfit', sans-serif;

    ✌️ I hope this helps you and happy coding!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord