Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code card

Omar Adel 30

@OmarAdelAttia

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feel free to add any comments to improve my coding skills

Community feedback

Adriano 34,090

@AdrianoEscarabote

Posted

Hi Omar Adel, how are you?

I really liked the result of your project, but I have some tips that I think you will enjoy:

Center your component like this:

body {
    display: flex;
    align-items: center;
    justify-content: center;
    flex-direction: column;
    margin: 0;
    padding: 0;
}

As you know this project is based only on one page component, so no h1 is needed! because we don't know if this page will have a more important component, but it's always good to prevent accessibility errors so I think it would be good for you to add an h1 in this component, besides being a good practice for when you are developing larger sites, don't worry forget about h1.

The rest is great!

I hope it helps... 👍

Marked as helpful

1

Omar Adel 30

@OmarAdelAttia

Posted

@AdrianoEscarabote I really liked your tips. Thank you and I really appreciate your help in improving my coding skills :D

1
Adriano 34,090

@AdrianoEscarabote

Posted

@OmarAdelAttia happy coding!!!

0

@Hamid210545

Posted

Hello ..... you have done an amazing job.... but let me correct you ... your card is not in center of the screen as per as design requirements.... but you can fix it by taking one simple step: by setting the properties of body tag { display: flex ; justify-content: center ; align-items: center ; } ............... I hope this will fix your problem............ Thanks!

Marked as helpful

1

Omar Adel 30

@OmarAdelAttia

Posted

@Hamid210545 Thank you Hamid for your help, I will consider it in the next project and will fix it in the current project too :D

0

@Hamid210545

Posted

@OmarAdelAttia You are always welcome💖

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord