Skip to content
Submitted 4 months ago

QR code card chanllenge solution

Mohamed khlifi•150
@Mohamedkh369
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am proud of starting to actually putting my skills into practice , and finally achieving the goal while learning about my strengths and areas i lack practice in, perhaps next time i should deepen my knowledge regarding the css flex box as it seems a very important concept in css.

What challenges did you encounter, and how did you overcome them?

this project was a bit simple actually , how ever i had to learn more about git and github which turned out pretty useful and simple once you understand them.

What specific areas of your project would you like help with?

for the meantime , none.

Community feedback

  • Sherline Au•170
    @sherlineauPosted 4 months ago

    Hello, Overall everything looks good, the only gripe I have is the use of paragraph tags and id's. If you wanted to reuse this card's styling without needing to "hard-code" each id, you could set the first p tag as a heading tag. Styling the tags keeps the sites styles consistent, for accents pieces you can add utilize the tag's id property.

    <section class="card-body">
      <h3> Improve your front-end skills by building projects</p>
      <p> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level
      </p>
</section>

h3{
    font-size: 1.4rem;
    font-weight: bold;
}
p{
color: gray;
}
    Marked as helpful
    0
    Mohamed khlifi•150
    @Mohamedkh369Posted 4 months ago

    @sherlineau I appreciate it , thank you for your feedback.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord