QR Code card challenge

Community feedback

• 

  Bernardus•1,095

  @BernardusPHPosted over 2 years ago

  Hey PALETTEJACK’S, People use min-height:100vh; in the body to let the body be 100% of the device height mostly, but you can use it with flex/grid to center vertically in the screen bc how can you move something vertically(not including position/transform) unless you have a set height? And yes its the easiest way and less hassle

  For your px problem lets give an example(also you can remove the card's height). Your card which is set at 280px width. There is nothing wrong with hard coding with px like this, but lets say your card had to change for mobile use, like it needs to be 200px instead? Then you need to use @media to fix that. If you really don't like hard coding with px then I would recommend using clamp which is awesome.

  Also just a tip but pls add *{box-sizing:border-box;}. less headache with width and padding

  Marked as helpful

  1

  ---

  

  Louie•170

  @PaletteJackPosted over 2 years ago

  @BernardusPH Awesome, I didn't know about clamp or box-sizing before. Thank you for the feedback!

  1