QR Code Card

Community feedback

• 

  romyanand•70

  @romyanandPosted about 1 year ago

  Hey👋. First of all congratulations for completing the challenge. I saw the GitHub code, and certainly, there are not many unnecessary divs in my opinion. Although you can do these things to make it more like the design provided if you would like to do so:

  1. I wouldn't suggest defining a height/min-height/max-height for the body. Height is something that's already adjusted as our content grows and shrinks. If you want to make something look a bit more in height, you can add top and bottom padding.

  2. You can also define a min-width and max-width for the container. Being said all this, Your design looks great👍. All the best!

  Marked as helpful

  0

  ---

  

  William Smith•10

  @WillxWinterPosted about 1 year ago

  @romyanand Thank you! Im going to apply this and see how it turns out, I didn’t have a lot of div in my final code, but In the beginning I had a ton and ended up getting stuck, but I got some help from the community and found my way through. I really appreciate the feedback, and I’m also open to any resources that may help me get a better understanding of some basics.

  0
• 

  williamcburks•0

  @williamcburksPosted about 1 year ago

  great information

  0