QR Code card

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, Anton! 👋

  Nice work on this challenge! 👍

  Two things can be done better.

  • It's great that the alternative text of the QR code tells the users the exact use case of the QR code which is going to navigate the users to the Frontend Mentor site. But, I would recommend removing the word "Scan". It is not a call to action like a link or button so telling the users about the image is good enough.
  • Put the attribution outside the main landmark. It should live on the footer landmark. It's simply because the attribution is a different type of content from the card.

  Hope this helps. 🙂

  2
• 

  Paweł•1,030

  @Pawel-GnatPosted over 2 years ago

  Good job with your challenge! Try to use rem/em in your next task, code your CSS in your css sheet only (style.css) and I'm not sure if that wrapper div was necessary here :)

  Good luck :)

  1