Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code card

P
Djole-zr 90

@Djole-zr

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@AGutierrezR

Posted

Hello there 👋. Good job on completing the challenge!

I have some suggestions about your code that might interest you.

CSS and Styling:

  • You could limit the text width using the ch unit, this could be a better approach than a rem unit.
  • Implement CSS custom properties to define and utilize project colors more easily.
  • Instead of fixed widths, employ max-width and min-width for flexible and responsive design.
  • Let the content decide the height of the elements. Use padding and margins strategically for this purpose.
  • The body should not have its height limited. Instead of using height: 100vh, use min-height: 100vh.

Accessibility and Semantic HTML:

  • The icons/illustration images are decorative, so their alt text must be emptyalt="".

I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!

Happy coding!

Marked as helpful

1

P
Djole-zr 90

@Djole-zr

Posted

@AGutierrezR Thank you so much. This is really helpful. I hope I will be hearing more from you, on my future challenges.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord