QR code card

Community feedback

• 

  Andrés Gutiérrez Ramírez•2,470

  @AGutierrezRPosted 11 months ago

  Hello there 👋. Good job on completing the challenge!

  I have some suggestions about your code that might interest you.

  CSS and Styling:

  • You could limit the text width using the ch unit, this could be a better approach than a rem unit.
  • Implement CSS custom properties to define and utilize project colors more easily.
  • Instead of fixed widths, employ max-width and min-width for flexible and responsive design.
  • Let the content decide the height of the elements. Use padding and margins strategically for this purpose.
  • The body should not have its height limited. Instead of using height: 100vh, use min-height: 100vh.

  Accessibility and Semantic HTML:

  • The icons/illustration images are decorative, so their alt text must be empty: alt="".

  I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!

  Happy coding!

  Marked as helpful

  1

  ---

  

  P

  Djole-zr•90

  @Djole-zrPosted 11 months ago

  @AGutierrezR Thank you so much. This is really helpful. I hope I will be hearing more from you, on my future challenges.

  0