Andrés Gutiérrez Ramírez• 2,510
@AGutierrezR
Posted
Hello there 👋. Good job on completing the challenge!
I have some suggestions about your code that might interest you.
CSS and Styling:
- You could limit the text width using the
ch
unit, this could be a better approach than arem
unit. - Implement CSS custom properties to define and utilize project colors more easily.
- Instead of fixed widths, employ
max-width
andmin-width
for flexible and responsive design. - Let the content decide the height of the elements. Use padding and margins strategically for this purpose.
- The
body
should not have itsheight
limited. Instead of usingheight: 100vh
, usemin-height: 100vh
.
Accessibility and Semantic HTML:
- The icons/illustration images are decorative, so their alt text must be empty:
alt=""
.
I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!
Happy coding!
Marked as helpful
1