QR code card

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted over 2 years ago

  Hello there! Great work with this one. Regarding the solution you submitted, I think you should know the following notes…

  • This part could be simplified into...

  <div class="qr-title">
          <h1>Improve your front-end skills by building projects</h1>
        </div>
        <div class="description">
          <p> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
        </div>
  
  Into:
  <section class="sample name here">
          <h1>Improve your front-end skills by building projects</h1>
          <p> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
  </section>
  

  • The font size of h1 can be adjusted into font-size: 20px;
  • Add the background: var(--Light-gray); in the body rule set

  On the contrary:

  • The HTML structure is done well. You utilized the semantic tags properly
  • The code is clean and neat
  • The design's details is well implemented
  • Used proper link for the font style and weights
  • The CSS structure is well organized.

  Above all, The design looks good. Keep it up!

  Marked as helpful

  1

  ---

  

  Azeem Saifi•370

  @saifion33Posted over 2 years ago

  @RioCantre Thanks Rio your feedback is helpful for me

  0