QR code Card

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 11 months ago

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify the "main" section of a page. Since the card is the only main content, the <main> can also be the card. You certainly don't need all of those divs! Make .container into <main>, and have a img>, <h1> and <p> inside it - that's all you need.

  • The alt text should be descriptive, and in this example, it also needs to say where it leads (frontendmentor.io).

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • Use the style guide to find the correct font-family.

  • font-size must never be in px. This is bad for accessibility, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • Remove the margin on body, it is not needed. To center the card horizontally and vertically, use Flexbox on the body:

  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100vh;
  

  • Remove height and margin on the image.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • Finally, I would also reduce the padding on the card a little.

  Hope this is helpful - good luck!

  0