QR code by Megumi

Community feedback

• 

  Arslan Ahmed•50

  @ArslanAIENGRPosted 4 months ago

  Hi!

  Congrats on completing this project.

  Things to improve here.

  I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

  Try experimenting with the CSS layout tool Flexbox, it will help you greatly structuring elements on your webpage.

  You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

  I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.

  Try using semantic HTML elements like main, section and article.

  Try using using relative CSS units like rem and em they make your layout more adaptable.

  Be careful with setting a fixed width and height on your elements. If the content in these elements grows beyond these restrictions you’ll run into overflow issues. Keeping the height at auto - which block elements are by default - will be fine in most cases.

  Try styling your elements using classes instead of ID’s. Most of the time they are the better choice. ID’s are mostly used to select elements using JavaScript, navigation on the page itself and to style unique elements.

  you can get assistance by contacting me on email: [email protected] I will feel happy to help you okay thanks

  Marked as helpful

  0

  ---

  

  Megumi Nagumo•10

  @Megumi-NagumoPosted 4 months ago

  @ArslanAIENGR Thank you so much for having looked at my code and your comment! I will practice more and learn to code with flexibility. :)

  0

  

  Arslan Ahmed•50

  @ArslanAIENGRPosted 4 months ago

  @Megumi-Nagumo Good Job

  0
• 

  Lyna•260

  @lynaIFRPosted 4 months ago

  Congrats on completing this project! At first glance, it seems you didn't see the design guide provided in the project folder, I invite you to take a look at it to better understand the requirements, I also took a look at your code, you should know that the attribution shouldn't be in the card (you can also take it off your website if you want), I invite you to check Josh Comeau for CSS reset, there is no need for the id; you can use other tags like h for the first p, using values for the padding and margin can be chaotic at some point, try flex box or grid and let the browser center elements for you If you have questions I'll be happy to help !

  0

  ---

  

  Megumi Nagumo•10

  @Megumi-NagumoPosted 4 months ago

  Hi @lynaIFR! Thank you so much for having looked at my code and your comment! yes, after coming across this platform, I just went straight to the project without reading through the guide ^ ^; I've just started to learn programming a few months ago. I will practice more and learn to code with flexibility. :)

  0
• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @Megumi-Nagumo

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

  Things you could improve ✍️

  • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

  • Try experimenting with the CSS layout tool Flexbox, it will help you greatly structuring elements on your webpage.

  • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

  • I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.

  • Try using semantic HTML elements like main, section and article.

  • Try using using relative CSS units like rem and em they make your layout more adaptable.

  • Be careful with setting a fixed width and height on your elements. If the content in these elements grows beyond these restrictions you’ll run into overflow issues. Keeping the height at auto - which block elements are by default - will be fine in most cases.

  • Try styling your elements using classes instead of ID’s. Most of the time they are the better choice. ID’s are mostly used to select elements using JavaScript, navigation on the page itself and to style unique elements.

  I hope you find my feedback helpful! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  0

  ---

  

  Megumi Nagumo•10

  @Megumi-NagumoPosted 4 months ago

  Hi @DylandeBruijn, thank you so much for having looked at my code and your detailed comment! I really appreaciate it. I will work on structuring more by trying other projects. I would be happy if you would take a look at them :D Merci

  0