QR CODE BY MD Byte

Community feedback

• 

  P

  Øystein Håberg•10,390

  @Islandstone89Posted about 2 months ago

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a <main>.

  • Remove <picture>, it is used when we want the browser to choose between different alternatives of an image, depending on the screen size. A simple <img> is all you need in this project.

  • Wrap the footer text in a <p>.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I recommend adding 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • "Outfit" is a sans-serif font, so change font-family: "Outfit", serif to font-family: "Outfit", sans-serif.

  • Remove the margin on the card.

  • On body, change justify-content: space-between to justify-content: center, and add align-items: center, so the card gets centered vertically. Also, add a gap of around 2rem to create space between the main and the footer.

  • max-width on the card should be in rem. Around 20rem will work fine.

  • Remember that all font sizes must be in rem.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • It's common to set display: block on images. You wouldn't need to set it to inline, as that is the default value.

  Marked as helpful

  1

  ---

  

  MD Byte•150

  @marupovdostonPosted about 2 months ago

  @Islandstone89 Men tushundim. Keyingi safar fikringizni inobatga olaman

  0
• 

  vaibhu252frontend•40

  @vaibhu252frontendPosted about 2 months ago

  code is well structure

  Marked as helpful

  0

  ---

  

  MD Byte•150

  @marupovdostonPosted about 2 months ago

  @vaibhu252frontend мне приятно услышать твой комментарий

  0