QR code by HTML and CSS

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted about 1 year ago

  To add to the tips above:

  • Fonts should be linked in the head of the HTML, not imported in the CSS.

  • Since all text is center-aligned, you can take use of inheritance by placing the text-align: center on the body.

  • Container max-width is still in px 🙂

  Marked as helpful

  1

  ---

  

  Ahlam•300

  @AhlamAb22Posted about 1 year ago

  @Islandstone89 Thank you! I forgot about "px" in the max-width, and I just modified it and other points you mentioned

  1
• 

  T

  Grace•31,270

  @grace-snowPosted about 1 year ago

  As promised, here is some feedback :)

  1. You need to use landmarks. This should have a main for the container and footer for the attribution, not divs
  2. Alt text is human-readable content. It is not code. This image is extremely important content so the alt must say what the image is (QR code) and where it goes (to www.FrontEndMentor.io)
  3. The container must not have a width. Instead, use max-width and make sure it is in rem, not px. This means that it will still work for people who change their base font size (estimated at 20% of the population)
  4. Make sure you update the link with your name to go somewhere, like your frontend mentor profile page
  5. Either the container needs a little margin, or the body needs a little padding. This stops the component from hitting screen edges.

  Marked as helpful

  1

  ---

  

  Ahlam•300

  @AhlamAb22Posted about 1 year ago

  @grace-snow Thank you! I will work on that

  0