QR Code

Community feedback

• 

  P

  Johnny Gérard•850

  @johnnygerardPosted 30 days ago

  Hello,

  I see that your images are not loading. It is probably because they are in the wrong folder. I think Netlify uses /public.

  So you can move images/favicon-32x32.png to public/images/favicon-32x32.png.

  1

  ---

  

  P

  Karolina Pietraś•40

  @ilierettePosted 30 days ago

  @johnnygerard Hello! Yes, I noticed also problems with CSS loading, so I changed to Vercel. I should work right now

  0

  

  P

  Johnny Gérard•850

  @johnnygerardPosted 30 days ago

  @ilierette All good!

  Since you asked about CSS units, I recommend you use rem units as much as possible.

  The Figma Dev mode allows selecting px or rem units.

  There are cases where you should keep using px units, such as a border of 1px or a horizontal rule of 1px.

  Em units are less often used. You should use em units when you need to size an element relative to the current font size (which is inherited if unspecified).

  Marked as helpful

  1

  

  P

  Karolina Pietraś•40

  @ilierettePosted 30 days ago

  @johnnygerard Thank you!

  0
• 

  Marcos Travaglini•6,210

  @BlackpachamamePosted 29 days ago

  Greetings! you have done a great job 😎

  📌 Some suggestions

  • To improve the semantics of your HTML, you can change your <div class="attribution"> to a <footer class="attribution">
  • Use min-height and max-width, this will help the content stretch or shrink if you need to. Unlike height and width which can cause your content to be cut off on certain screens. For example, use min-height: 100vh instead of height: 100vh
  • You can apply display: block to the image to remove the white space generated underneath. Although visually in this case it is irrelevant, it helps you better calculate the space with other elements

  0

  ---

  

  P

  Karolina Pietraś•40

  @ilierettePosted 11 days ago

  @Blackpachamame thank you! that was helpful 💕

  1
• 

  P

  Jonatan Samuelsson•490

  @jonatan-samuelssonPosted 30 days ago

  Nice work. I see your image doesn´t have rounded corners. This is because you´ve nested it´s selector inside the .card class selector. To solve it, either move the img class selector outside, or use an & .[YOURCLASSNAME] to properly nest it. Also, your HTML semantics could improve. Main with a class of card seems a bit off. Better to have a clean main and then a .card div. You´v also placed the attribution inside the card itself. It belongs outside, perhaps even in a footer element?

  0

  ---

  

  P

  Karolina Pietraś•40

  @ilierettePosted 30 days ago

  @jonatan-samuelsson Yeah, you are right. I refactored that with image, because on 320px it was to close to border, then completely forgot about borders.

  Also I'm new to semantics, so your feedback is helpful.

  0

  

  P

  Jonatan Samuelsson•490

  @jonatan-samuelssonPosted 29 days ago

  @ilierette Nice improvements, well done!

  0