Skip to content
Submitted over 2 years ago

QR Code

Mahmoud Attiyah•50
@M-Attiyah
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

  • advise me something

Community feedback

  • Travolgi 🍕•31,400
    @denieldenPosted over 2 years ago

    Hi Mahmoud, I took some time to look at your solution and you did a great job!

    Also add main tag and wrap the card for Accessibility and add descriptive text in the alt attribute of the image

    Overall you did well :)

    Hope this help and happy coding!

    Marked as helpful
    0
    Mahmoud Attiyah•50
    @M-AttiyahPosted over 2 years ago

    @denielden Thank you

    1
  • Naveen Gumaste•10,480
    @NaveenGumastePosted over 2 years ago

    Hello Mahmoud Attiyah ! Congo 👏 on completing this challenge

    Let's look at some of your issues, shall we:

    • First of all give the background color which is provided in style-guide.md

    • You should use h1 tag for the card title not p tag

    • Warp your card content around the main tag Ex: 👇

    <body>
<main class="container">
*all you content here*
</main>
</body>

    happy Coding😀

    Marked as helpful
    0
    Mahmoud Attiyah•50
    @M-AttiyahPosted over 2 years ago

    @Crazimonk Thank you, I appreciate your advice

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord