Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Salva 250

@salva-it

Posted

Congratulations

  • The code is generally good but could be improved with a few small changes

  • First, I suggest you put the <meta> in the top part of the <head>, this will make the browser process the viewport and charset tags first.

  • Alternative text Alt is empty for QR-code It is better to consider a text that will use this alternative text if the image is not loaded.

  • you use semantic code insted <div>

  • it is better you use google font google in html file insted css code

  • Head tags <h1> <h2> <h3> ... <h6> are very important in SEO, make sure you use these tags hierarchically In this project, you can put the main title in the <h1> instead of <h2>

  • your project isn't responsive it is better design responsive To display correctly on different platforms

good luck

0
Kalebe Max 150

@kalebemax

Posted

You´ve done great completing this project, realy impressive. I would add box-shadow aroud the main div just to get the exact same looks as the original. Other than that, it looks great.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord