Skip to content
Submitted over 2 years ago

QR Code

Pablo Montoya Varela•300
@PaliTriesToDesign
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Is it needed to put the image inside a div? It still confuses me a bit.

I feel like I'm learning something. It only took me about 20 minutes to build it.

Thanks!

Community feedback

  • TechNech•340
    @TechNechPosted over 2 years ago

    Hope you are doing good. I would suggest you these few quick fixes on your component site.

    • In your .container you don't need that much of margin you can do is to simplify that property to margin: 0 auto

    • Then add these properties height: 100vh; display: flex; flex-direction: column; justify-content: center; to your body css, which will center your component.

    • In .qr-text simplify padding: 1rem;

    • In your .qr-text__p add max-width: 25ch;

    Marked as helpful
    1
    Pablo Montoya Varela•300
    @PaliTriesToDesignPosted over 2 years ago

    @TechNech I really appreciate your help. Thanks!

    0
    TechNech•340
    @TechNechPosted over 2 years ago

    @PaliTriesToDesign Anytime! I would love to see those changes on the live site. Make those changes and push it on github.

    Happy coding :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord